From 886c62a3ff5aefca7b595a830ef2def5fedb636d Mon Sep 17 00:00:00 2001 From: Jan Kiszka Date: Fri, 17 Aug 2012 12:56:44 +0200 Subject: i82378: Remove bogus MMIO coalescing MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This MMIO area is an entry gate to legacy PC ISA devices, addressed via PIO over there. Quite a few of the PIO ports have side effects on access like starting/stopping timers that must be executed properly ordered /wrt the CPU. So we have to remove the coalescing mark. Acked-by: Hervé Poussineau Acked-by: Andreas Färber Signed-off-by: Jan Kiszka Signed-off-by: Anthony Liguori (cherry picked from commit 0ec64507a5e6366e6d8070a82c866b935f687ed9) Signed-off-by: Michael Roth --- hw/i82378.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i82378.c b/hw/i82378.c index 9b11d907e..2123c142a 100644 --- a/hw/i82378.c +++ b/hw/i82378.c @@ -225,7 +225,6 @@ static int pci_i82378_init(PCIDevice *dev) pci_register_bar(dev, 0, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->io); memory_region_init_io(&s->mem, &i82378_mem_ops, s, "i82378-mem", 0x01000000); - memory_region_set_coalescing(&s->mem); pci_register_bar(dev, 1, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->mem); /* Make I/O address read only */ -- cgit v1.2.3