diff options
author | Jan Kiszka <jan.kiszka@siemens.com> | 2012-05-28 15:03:41 +0200 |
---|---|---|
committer | Avi Kivity <avi@redhat.com> | 2012-05-29 16:59:49 +0300 |
commit | 01b1e19e0b3b9511cdabbe129135024f6bf3087e (patch) | |
tree | bc5880094034e805cc899c4e81743a50cb4ab690 | |
parent | 18a188f66237e7b38fc8133d3862e5904c0e7ffb (diff) |
device assignment: Drop support for raw ioport access
If the kernel does not support ioport access via sysfs, passthrough can
only help if the unlikely case that a port <= 0x3ff is provided by the
device. So drop this to simplify the code and to allow dropping the
corresponding KVM infrastructure in preparation of upstream merge.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
-rw-r--r-- | hw/device-assignment.c | 20 |
1 files changed, 3 insertions, 17 deletions
diff --git a/hw/device-assignment.c b/hw/device-assignment.c index 1daadb92e..9ad5de56a 100644 --- a/hw/device-assignment.c +++ b/hw/device-assignment.c @@ -245,18 +245,8 @@ static void assigned_dev_ioport_setup(PCIDevice *pci_dev, int region_num, { AssignedDevice *r_dev = DO_UPCAST(AssignedDevice, dev, pci_dev); AssignedDevRegion *region = &r_dev->v_addrs[region_num]; - int r; region->e_size = size; - - if (region->region->resource_fd < 0) { - r = kvm_add_ioport_region(region->u.r_baseport, region->r_size, - pci_dev->qdev.hotplugged); - if (r < 0) { - fprintf(stderr, "%s: failed to enable ioport access (%m)\n", - __func__); - } - } memory_region_init(®ion->container, "assigned-dev-container", size); memory_region_init_io(®ion->real_iomem, &assigned_dev_ioport_ops, r_dev->v_addrs + region_num, @@ -440,10 +430,10 @@ static int assigned_dev_register_regions(PCIRegion *io_regions, ret); abort(); } else if (errno != EINVAL) { - fprintf(stderr, "Using raw in/out ioport access (sysfs - %s)\n", - strerror(errno)); + fprintf(stderr, + "Kernel doesn't support ioport resource access.\n"); close(pci_dev->v_addrs[i].region->resource_fd); - pci_dev->v_addrs[i].region->resource_fd = -1; + return -1; } pci_dev->v_addrs[i].u.r_baseport = cur_region->base_addr; @@ -647,10 +637,6 @@ static void free_assigned_device(AssignedDevice *dev) continue; } if (pci_region->type & IORESOURCE_IO) { - if (pci_region->resource_fd < 0) { - kvm_remove_ioport_region(region->u.r_baseport, region->r_size, - dev->dev.qdev.hotplugged); - } memory_region_del_subregion(®ion->container, ®ion->real_iomem); memory_region_destroy(®ion->real_iomem); |