aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBjørn Mork <bjorn@mork.no>2012-10-07 19:31:23 +0200
committerBjørn Mork <bjorn@mork.no>2012-10-18 22:39:40 +0200
commit01675d52ee91a35369621b4aad095354243ab696 (patch)
tree547336da48f4075ac387b1922fe9b3c02f4a9360
parent73f740cd5a3b6e999be4df9a7d6d78baa0033486 (diff)
net: cdc_ncm: use device rx_max value if update failed
If the device refuses our updated value, then we must be prepared to receive URBs as big as the device wants to send. Set rx_max to the device provided value on error. Signed-off-by: Bjørn Mork <bjorn@mork.no>
-rw-r--r--drivers/net/usb/cdc_ncm.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index 4cd582a4f62..6a65662aa9d 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -251,8 +251,11 @@ static u8 cdc_ncm_setup(struct cdc_ncm_ctx *ctx)
kfree(dwNtbInMaxSize);
}
size_err:
- if (err < 0)
- pr_debug("Setting NTB Input Size failed\n");
+ if (err < 0) {
+ /* failed, so attempt to use the device suggested size */
+ ctx->rx_max = le32_to_cpu(ctx->ncm_parm.dwNtbInMaxSize);
+ pr_debug("Setting NTB Input Size failed, reverting to %u\n", ctx->rx_max);
+ }
}
/* verify maximum size of transmitted NTB in bytes */